-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sadhika tadinada PR 3 #2826
base: master
Are you sure you want to change the base?
sadhika tadinada PR 3 #2826
Conversation
🙏 Thanks for your pull request @sadhikatadinada, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aloha @sadhikatadinada and thanks for your contribution.
Not accepting any JS for contribution,
- Please either close your PR or address the feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS Not accepted in contribution
As the README.md states - we do not accept contribution using JS
The contribution should only be about an animation / creative animation without any logic or use of third part library to handle css
Observing what you have here:
What you could do is using CSS to animate all cells to show a tic tac toe round.
Using css timers to delay cells if needed.
Either close this PR / either adjust this PR so it does not use ANY JS
🙏 Thanks for your pull request @sadhikatadinada, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
🙏 Thanks for your pull request @sadhikatadinada, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.
While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!
What I did
Optional: Edit this to tell us what you did!
Pull request checklist
meta.json
file.<github_username>-<art_name>
without the <>.index.html
andstyles.css
.index.html
styles.css
meta.json
with:githubHandle
: being your unique github user name,artName
: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect